This repository has been archived by the owner on May 3, 2024. It is now read-only.
[REFACTOR] React to HTML plugin #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 681 kB ℹ️ View Unchanged
|
code-forger
approved these changes
Nov 9, 2022
dogpatch626
approved these changes
Nov 9, 2022
10xLaCroixDrinker
suggested changes
Nov 13, 2022
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2019 American Express Travel Related Services Company, Inc. | |||
| * Copyright 2022 American Express Travel Related Services Company, Inc. | |||
There was a problem hiding this comment.
This does not need to be updated
| expect(response.body).toContain('Sorry, we are unable to load this page at this time. Please try again later.'); | ||
| }); | ||
|
|
||
| it('invites the user to try again if the status code is 404', async () => { |
There was a problem hiding this comment.
Why try again on a 404?
There was a problem hiding this comment.
the "try again" is related to the message that's being rendered: "Please try again later." (see
)| res.timeout = timeout; | ||
| return res; | ||
| .then((reply) => { | ||
| // eslint-disable-next-line no-param-reassign |
There was a problem hiding this comment.
Add comment explaining any rules being disabled
| jest.spyOn(console, 'log').mockImplementation(() => {}); | ||
| jest.spyOn(console, 'error').mockImplementation(() => {}); | ||
| jest.spyOn(console, 'warn').mockImplementationOnce(() => {}); | ||
| jest.spyOn(console, 'info').mockImplementation(() => { }); |
There was a problem hiding this comment.
Was this a lint error?
There was a problem hiding this comment.
just copy/paste from another test
| it('warns if url cannot be fetched', async () => { | ||
| const fetchError = new Error('getaddrinfo ENOTFOUND'); | ||
| global.fetch = jest.fn(() => Promise.reject(fetchError)); | ||
| test('calls the expected hooks to render html', async () => { |
There was a problem hiding this comment.
Use it rather than test throughout
| @@ -53,10 +52,10 @@ const renderForStaticMarkupSpy = jest.spyOn(reactRendering, 'renderForStaticMark | |||
|
|
|||
| describe('createRequestHtmlFragment', () => { | |||
| jest.spyOn(console, 'error').mockImplementation(() => {}); | |||
| console.error = jest.fn(); | |||
There was a problem hiding this comment.
This should not be needed
14 tasks
bishnubista
approved these changes
Nov 28, 2022
10xLaCroixDrinker
approved these changes
Nov 28, 2022
14 tasks
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fastify plugin that takes care of creating the redux store, converting react into html, and responding
Motivation and Context
This is part of the ExpressJS -> Fastify migration. The plugin allows us to simply reply with
reply.sendHtml()from any routeHow Has This Been Tested?
Manual, Unit Testing, Integration Testing
Types of Changes
Checklist:
What is the Impact to Developers Using One App?