Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Switch to Fastify logger #1084

Merged
merged 15 commits into from
Sep 5, 2023
Merged

Switch to Fastify logger #1084

merged 15 commits into from
Sep 5, 2023

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Switch from lumberjack to pino/fastify logger

Motivation and Context

  • Performance improvement
  • Request correlation
  • Prep for OTel in v6

How Has This Been Tested?

Ran npm start -- --root-module-name=frank-lloyd-root --log-level=info --log-format machine > pino-test.log in this branch and in main. Visited a 200 and a 404 route and diffed the output log files.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

With this change we lose the "firendly" formatter in development because we dont have the beforeWrite and afterWrite API in pino that we have in lumberjack that are needed for the ora spinners.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Size Change: 0 B

Total Size: 689 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 389 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 122 kB

compressed-size-action

@Matthew-Mallimo Matthew-Mallimo requested a review from a team August 10, 2023 14:40
package.json Outdated Show resolved Hide resolved
@dogpatch626
Copy link
Contributor

Should lumberjack be removed from dependencies?

@10xLaCroixDrinker
Copy link
Member Author

Should lumberjack be removed from dependencies?

#1084 (comment)

JAdshead
JAdshead previously approved these changes Aug 29, 2023
@JAdshead JAdshead requested a review from a team August 31, 2023 15:34
* permissions and limitations under the License.
*/

import os from 'os';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import os from 'os';
import os from 'node:os';

* permissions and limitations under the License.
*/

import util from 'util';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import util from 'util';
import util from 'node:util';

@10xLaCroixDrinker 10xLaCroixDrinker merged commit 33fa971 into main Sep 5, 2023
7 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/fastify-logging branch September 5, 2023 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants