This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 689 kB ℹ️ View Unchanged
|
15 tasks
Matthew-Mallimo
previously approved these changes
Aug 24, 2023
Should lumberjack be removed from dependencies? |
|
JAdshead
previously approved these changes
Aug 29, 2023
JAdshead
approved these changes
Aug 29, 2023
Matthew-Mallimo
approved these changes
Sep 5, 2023
* permissions and limitations under the License. | ||
*/ | ||
|
||
import os from 'os'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
import os from 'os'; | |
import os from 'node:os'; |
* permissions and limitations under the License. | ||
*/ | ||
|
||
import util from 'util'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
import util from 'util'; | |
import util from 'node:util'; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from lumberjack to pino/fastify logger
Motivation and Context
How Has This Been Tested?
Ran
npm start -- --root-module-name=frank-lloyd-root --log-level=info --log-format machine > pino-test.log
in this branch and in main. Visited a 200 and a 404 route and diffed the output log files.Types of Changes
Checklist:
What is the Impact to Developers Using One App?
With this change we lose the "firendly" formatter in development because we dont have the beforeWrite and afterWrite API in pino that we have in lumberjack that are needed for the ora spinners.