This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
feat(cache-module): implemented cached modules #1094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 688 kB ℹ️ View Unchanged
|
bishnubista
force-pushed
the
feat/cache-modules
branch
from
August 21, 2023 22:29
7562b15
to
4388fc2
Compare
Matthew-Mallimo
suggested changes
Aug 30, 2023
src/server/utils/cacheCDNModules.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file be renamed to cdnCache
bishnubista
force-pushed
the
feat/cache-modules
branch
from
September 5, 2023 21:39
64eae64
to
a75866e
Compare
Matthew-Mallimo
approved these changes
Sep 6, 2023
code-forger
approved these changes
Sep 11, 2023
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache CDN modules on startup.
Description
Motivation and Context
This feature helps to cache CDN modules in users machine. It helps to start application faster locally.
How Has This Been Tested?
Yes, running one app locally providing module map.
NODE_ENV=development npm start -- --module-map-url=<your-remote-module-map-url> --root-module-name=<your-root-module-name>
First run will create a .one-app folder and .one-app-module-cache file.
.one-app-module-cache
stores module data. Subsequent run will first look on cache file before making api call.Types of Changes
Checklist:
What is the Impact to Developers Using One App?
One app start time will be faster.