This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 712 kB ℹ️ View Unchanged
|
JAdshead
force-pushed
the
test/integration-m1-support
branch
from
January 8, 2024 20:31
44f0333
to
926790c
Compare
JAdshead
force-pushed
the
test/integration-m1-support
branch
from
January 11, 2024 22:02
a9b1ab7
to
3330cb0
Compare
JAdshead
force-pushed
the
test/integration-m1-support
branch
from
January 12, 2024 19:36
3330cb0
to
eb3f724
Compare
10xLaCroixDrinker
suggested changes
Jan 12, 2024
JAdshead
force-pushed
the
test/integration-m1-support
branch
2 times, most recently
from
January 15, 2024 17:26
85eb001
to
40ea1d1
Compare
JAdshead
force-pushed
the
test/integration-m1-support
branch
from
January 15, 2024 17:37
40ea1d1
to
2a72b14
Compare
JAdshead
force-pushed
the
test/integration-m1-support
branch
2 times, most recently
from
January 15, 2024 17:56
9a64b5b
to
3423f4f
Compare
JAdshead
force-pushed
the
test/integration-m1-support
branch
from
January 15, 2024 18:07
3423f4f
to
f168eec
Compare
10xLaCroixDrinker
approved these changes
Jan 15, 2024
Matthew-Mallimo
approved these changes
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The selenium image does not work on arm processor such as apples m1.
This changes from selenium to seleniarm standalone image to support running integration tests on systems with arm processor.
Added
ONE_DANGEROUSLY_SKIP_API_IMAGES_BUILD
flag to skip rebuilding api images for prod sample.Motivation and Context
Contributors who work on new apple computers currently are unable to run the prod sample server and run integration tests locally.
How Has This Been Tested?
Locally with m1 and intel chips and integration test suite run through actions.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?