Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

test(integration): use seleniarm #1236

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Jan 8, 2024

Description

The selenium image does not work on arm processor such as apples m1.
This changes from selenium to seleniarm standalone image to support running integration tests on systems with arm processor.

Added ONE_DANGEROUSLY_SKIP_API_IMAGES_BUILD flag to skip rebuilding api images for prod sample.

Motivation and Context

Contributors who work on new apple computers currently are unable to run the prod sample server and run integration tests locally.

How Has This Been Tested?

Locally with m1 and intel chips and integration test suite run through actions.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@github-actions github-actions bot added the test label Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Size Change: 0 B

Total Size: 712 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@JAdshead JAdshead marked this pull request as ready for review January 10, 2024 21:08
@JAdshead JAdshead requested review from a team as code owners January 10, 2024 21:08
prod-sample/README.md Outdated Show resolved Hide resolved
@JAdshead JAdshead force-pushed the test/integration-m1-support branch 2 times, most recently from 85eb001 to 40ea1d1 Compare January 15, 2024 17:26
@JAdshead JAdshead marked this pull request as draft January 15, 2024 17:35
@JAdshead JAdshead force-pushed the test/integration-m1-support branch 2 times, most recently from 9a64b5b to 3423f4f Compare January 15, 2024 17:56
@JAdshead JAdshead marked this pull request as ready for review January 15, 2024 18:27
@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team January 15, 2024 18:38
@Matthew-Mallimo Matthew-Mallimo merged commit 8dcf111 into main Jan 16, 2024
9 checks passed
@Matthew-Mallimo Matthew-Mallimo deleted the test/integration-m1-support branch January 16, 2024 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants