Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Feat/dotenv5 #1337

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Feat/dotenv5 #1337

merged 3 commits into from
Mar 25, 2024

Conversation

Matthew-Mallimo
Copy link
Member

Description

Add Dotenv support

Motivation and Context

Allow users to define environment variables with a file on startup.

How Has This Been Tested?

Drafted a pre-release and tested in an environment
https://hub.docker.com/layers/oneamex/one-app/5.24.0-dotenv-oneapp5.1/images/sha256-c45a64877afe76fb67245cd926701aa9c30149d28552dceb412443483ee7ed9b?context=explore

Also ran the image locally to ensure modules can supply their own file locally.

NOTE

one-app-runner currently has a bug where it will ignore the startup command defined in the Dockerfile, and start the process with its own command. We will need to resolve this, but it breaks nothing currently.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

New feature!

Copy link
Contributor

github-actions bot commented Mar 25, 2024

Size Change: 0 B

Total Size: 694 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 159 kB
./build/app/app~vendors.js 401 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 120 kB

compressed-size-action

code-forger
code-forger previously approved these changes Mar 25, 2024
@code-forger code-forger requested a review from a team March 25, 2024 15:53
@10xLaCroixDrinker
Copy link
Member

Should we include it in the docker compose files for prod-sample?

@Matthew-Mallimo
Copy link
Member Author

Should we include it in the docker compose files for prod-sample?

Yes, let me add it

@Matthew-Mallimo
Copy link
Member Author

@10xLaCroixDrinker Added to prod samples in 51e7340

@10xLaCroixDrinker 10xLaCroixDrinker merged commit 8c99955 into 5.x.x Mar 25, 2024
8 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feat/dotenv5 branch March 25, 2024 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants