Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Fix release workflow #1339

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix release workflow #1339

merged 1 commit into from
Mar 25, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

@10xLaCroixDrinker 10xLaCroixDrinker commented Mar 25, 2024

Description

Update to conventional-changelog-cli@4.1.0

This was incorrectly flagged as not upgradable in #1327 due to the conflicting version that standard-version relies on. Seems upgrading @commitlint/cli and @commitlint/config-conventional without updating conventional-changelog-cli may have been the cause of this issue.

Motivation and Context

Release PRs are generating bad changelogs

How Has This Been Tested?

Ran $ npm run release

Before

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9391174..1282f8a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@

 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

+
+
+
 # [6.10.0](https://github.com/americanexpress/one-app/compare/v6.9.2...v6.10.0) (2024-02-16)

After

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9391174..f2432d8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,21 @@

 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

+# [6.11.0](https://github.com/americanexpress/one-app/compare/v6.10.0...v6.11.0) (2024-03-25)
+
+
+### Features
+
+* add dotenv support ([#1333](https://github.com/americanexpress/one-app/issues/1333)) ([3172251](https://github.com/americanexpress/one-app/commit/3172251033e3c9740441d395515f693dc6262434))
+* **logger:** use a pretty logger in locale development with OTel enabled ([#1292](https://github.com/americanexpress/one-app/issues/1292)) ([a810139](https://github.com/americanexpress/one-app/commit/a8101398eb9145ea94530550aa7c4d03d1e4aa3d))
+* **tracing:** add OpenTelemetry tracing ([#1214](https://github.com/americanexpress/one-app/issues/1214)) ([aad2538](https://github.com/americanexpress/one-app/commit/aad2538ef5bd814cb020facc5d9667e200a59f89))
+
+
+### Reverts
+
+* Revert "refactor: upgrade to node 20" (#1332) ([eb811e3](https://github.com/americanexpress/one-app/commit/eb811e349769540a74e66807386b33e934bf1eee)), closes [#1332](https://github.com/americanexpress/one-app/issues/1332)
+
+
 # [6.10.0](https://github.com/americanexpress/one-app/compare/v6.9.2...v6.10.0) (2024-02-16)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

N/A

Copy link
Contributor

Size Change: 0 B

Total Size: 735 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 187 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

Copy link
Contributor

@PixnBits PixnBits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer being explicit when bypassing checks (the devs verify that not verifying the commit is appropriate :P) but not a blocker 👍

@@ -43,7 +43,7 @@
"set-middleware": "set-middleware",
"set-dev-endpoints": "node scripts/set-dev-endpoints.js",
"postinstall": "npm run build",
"release:standard-version": "standard-version",
"release:standard-version": "standard-version -n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"release:standard-version": "standard-version -n",
"release:standard-version": "standard-version --no-verify",

@10xLaCroixDrinker 10xLaCroixDrinker merged commit c3db195 into main Mar 25, 2024
10 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the bugfix/prepare-release branch March 25, 2024 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants