-
Notifications
You must be signed in to change notification settings - Fork 87
test(perf): new CLI for running and comparing perf tests #1389
Conversation
Size Change: 0 B Total Size: 232 kB ℹ️ View Unchanged
|
@@ -110,7 +111,7 @@ | |||
"accepts": "^1.3.8", | |||
"bytes": "^3.1.2", | |||
"cacheable-lookup": "^6.1.0", | |||
"chalk": "^4.1.2", | |||
"colorette": "^2.0.20", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change from chalk to colorette?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency. pino-pretty uses colorette, so most of the log coloring we do is actually already using colorette. It's also not ESM-only and we could actually consume any updates it gets.
"standard-version": "^9.5.0", | ||
"tar": "^6.2.1", | ||
"thread-stream": "^2.4.1", | ||
"ttest": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are split2 and ttest intentional installs? These are the two most typo looking package names I've seen in my life
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, yes they are intentional.
split2 is a fork of split, and ttest is for creating "t-tests"
Description
Adds new CLI for running and comparing perf tests.
There is also a minor refactor in
src
to remove chalk and use colorette (the same lib used by pino-pretty)Motivation and Context
First stage in a series of changes to automate performance testing.
The primary goal of the current commands in the CLI is to make it easier to run the tests and evaluate the performance.
How Has This Been Tested?
Running the new commands locally
Types of Changes
Checklist:
What is the Impact to Developers Using One App?