Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(clientErrorLogger): format console error message #382

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

infoxicator
Copy link
Contributor

Update One App Ducks to 4.2.1 to fix the clientErrorLogger attempting to spread a stringified object americanexpress/one-app-ducks#20

Description

Also added the util.inspect to console.error to log deep objects up to a maximum of 10 levels

Motivation and Context

How Has This Been Tested?

Unit tests
Tested making an API call to the client error logger to confirm expected functionality

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@infoxicator infoxicator requested a review from a team as a code owner November 26, 2020 16:52
@github-actions github-actions bot added the fix label Nov 26, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 267KB 79.5KB
runtime.js 15KB 5.4KB
vendors.js 117.4KB 36.4KB
app~vendors.js 401.4KB 106.6KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 281.8KB 82.6KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.8KB 47.1KB
legacy/app~vendors.js 417.2KB 109.3KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against bb6e319

JAdshead
JAdshead previously approved these changes Nov 30, 2020
@infoxicator infoxicator merged commit 03da190 into main Dec 2, 2020
@infoxicator infoxicator deleted the fix/format-client-error branch December 2, 2020 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants