-
Notifications
You must be signed in to change notification settings - Fork 87
feat(scripts): generate one-app-statics package #82
feat(scripts): generate one-app-statics package #82
Conversation
bd0a4d7
to
57c9a71
Compare
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
fe0c403
to
9362f2a
Compare
End to end release workflow was achieved in this branch https://github.com/infoxicator/one-app/blob/feat/actions-publish-statics/.github/workflows/docker_release.yml however, it requires changes to the build process here: https://github.com/infoxicator/one-app/blob/feat/actions-publish-statics/package.json#L22 and to the docker image here: https://github.com/infoxicator/one-app/blob/feat/actions-publish-statics/Dockerfile#L29 which is not ideal, so I have come up with an easier alternative and that is adding the |
Looks good. Very simple using jsdelivr 👍 |
Created a script to generate the. Thepackage.json
for theone-app-statics
packageone-app-statics
folder will contain the signed client assets generated by one app and published to npm so they can be accessed using jsDelivrpackage.json
inside the statics will be maintained by the release draft PRDescription
The script copies the version number from the mainpackage.json
postinstall.js
script and theindex.js
script of theone-app-statics
package so people do not use it by mistakeMotivation and Context
This change supports the deployment of static client assets so they can be loaded from a CDN
How Has This Been Tested?
~~Tested script using
node ./scripts/generate-statics-package-json.js
and ~~ uploaded npm package using travis, however the release cycle will be addressed on a separate PR using Github actions.Types of Changes
Checklist:
What is the Impact to Developers Using One App?
No Impact to users, this is used to support the One App release cycle