Rename level to tree_level #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, I'll look into fixing the test failures on master due to the ruby version requirement of nokogiri 1.7. |
|
Thanks |
… fix_level_method_name
|
Merged your changes, thanks for taking the time to look into this. I'll release gem version 2.6.1 with this fix shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have had a go at trying to fix the issue around the level described here: #58.
I am not sure if it is something you would want to add in but It does seem to solve the problem if replicate the scenario locally.
I have renamed the level method tree_level as suggested. I also think I have been able to allow level to to be used if level is not a column on the recode concerned. I have written some tests to cover such a scenario and tested manually in a rails app and it seem to work ok. Let me know what you think.
Also I spotted some typos in my previous work I have correct these and in the first commit so they can be cherry picked if the rest of the work is not wanted.