Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.1 Support #68

Merged
merged 3 commits into from
Sep 14, 2017
Merged

Rails 5.1 Support #68

merged 3 commits into from
Sep 14, 2017

Conversation

felixbuenemann
Copy link
Collaborator

@felixbuenemann felixbuenemann commented Sep 14, 2017

This adds Rails 5.1 to the CI matrix and fixes the following deprecation warnings with ActiveRecord 5.1:

DEPRECATION WARNING: The behavior of attribute_changed? inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after save returned (e.g. the opposite of what it returns now). To maintain the current behavior, use saved_change_to_attribute? instead. (called from update_parents_counter_cache at acts_as_tree/lib/acts_as_tree.rb:361)

DEPRECATION WARNING: The behavior of attribute_was inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after save returned (e.g. the opposite of what it returns now). To maintain the current behavior, use attribute_before_last_save instead. (called from update_parents_counter_cache at acts_as_tree/lib/acts_as_tree.rb:362)

Closes #67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant