Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

fix: Dimensions edited #103

Merged
merged 3 commits into from
Aug 13, 2019
Merged

fix: Dimensions edited #103

merged 3 commits into from
Aug 13, 2019

Conversation

ShivangiSingh17
Copy link
Member

Fixed #102

The dimensions are edited for the watermark to appear.

@auto-label auto-label bot added the fix label Aug 8, 2019
Copy link
Member

@yashk2000 yashk2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr :)
You have to add the dimensions to the dimens resource file if they are not already there. Please to that so that the build passes.

Copy link
Member

@yashk2000 yashk2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to request changes above, not approve.

Copy link
Member

@yashk2000 yashk2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ShivangiSingh17. Thank you 😁

@immadisairaj
Copy link
Member

@ShivangiSingh17 can you please resolve conflicts. And also would be better if screenshots are also added.

@yashk2000
Copy link
Member

@ShivangiSingh17 please resolve conflicts.

Copy link
Member

@ajay-prabhakar ajay-prabhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@yashk2000 yashk2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @ShivangiSingh17 🎉

@yashk2000
Copy link
Member

@immadisairaj merge.

@vchrombie
Copy link
Member

@ShivangiSingh17, thanks for the PR. 🙂
Merging it. 🎉

@vchrombie vchrombie merged commit 37f3fd2 into amfoss:development Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit textbox dimension
5 participants