-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr :)
You have to add the dimensions to the dimens resource file if they are not already there. Please to that so that the build passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to request changes above, not approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ShivangiSingh17. Thank you 😁
@ShivangiSingh17 can you please resolve conflicts. And also would be better if screenshots are also added. |
@ShivangiSingh17 please resolve conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @ShivangiSingh17 🎉
@immadisairaj merge. |
@ShivangiSingh17, thanks for the PR. 🙂 |
Fixed #102
The dimensions are edited for the watermark to appear.