This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
fix: Refactored the app code #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajay-prabhakar
suggested changes
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="update">Update</string> | ||
| <string name="error_notSelected">Please select any option</string> | ||
| <string name="fetch_name">name</string> | ||
| <string name="insert_data">Insert Data</string> | ||
| <string name="nothingselected">Nothing selected</string> | ||
| <string name="custompooja">Custom Pooja</string> | ||
| <string name="amount_in_rs">Amount: Rs.</string> | ||
| <string name="amount_in_rs">Amount:Rs.</string> |
There was a problem hiding this comment.
revert this change, it has a particular reason for giving some spaces
find it in ReadSingleData activity
|
to make it semantic PR title change it to |
athiranair2000
changed the title
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| @@ -3,25 +3,25 @@ | |||
| <string name="read">Read</string> | |||
| <string name="read_all">Read All</string> | |||
| <string name="empty">" "</string> | |||
| <string name="delete_donated">Selected To Delete Donated Money</string> | |||
| <string name="delete_pooja">Selected To Delete Registered Pooja</string> | |||
| <string name="delete_donated">Selected to delete donated money</string> | |||
There was a problem hiding this comment.
Make this Delete donated money
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="delete_donated">Selected To Delete Donated Money</string> | ||
| <string name="delete_pooja">Selected To Delete Registered Pooja</string> | ||
| <string name="delete_donated">Selected to delete donated money</string> | ||
| <string name="delete_pooja">Selected to delete registered Pooja</string> |
There was a problem hiding this comment.
Make this Delete registered pooja
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="selected_donate">Selected To Donate Money</string> | ||
| <string name="selected_register">Selected To Register New Pooja</string> | ||
| <string name="select_pooja_type">Select Pooja Type</string> | ||
| <string name="selected_donate">Selected to donate money</string> |
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="selected_register">Selected To Register New Pooja</string> | ||
| <string name="select_pooja_type">Select Pooja Type</string> | ||
| <string name="selected_donate">Selected to donate money</string> | ||
| <string name="selected_register">Selected to register new pooja</string> |
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="select_pooja_type">Select Pooja Type</string> | ||
| <string name="selected_donate">Selected to donate money</string> | ||
| <string name="selected_register">Selected to register new pooja</string> | ||
| <string name="select_pooja_type">Select pooja type</string> |
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="PAID">PAID</string> | ||
| <string name="NOT_PAID">NOT PAID</string> | ||
| <string name="valid_ID">Please enter a valid employee ID</string> | ||
| <string name="insert">Inserting your values..</string> | ||
| <string name="exception">exception</string> | ||
| <string name="UPDATE">Selected To update donated money details</string> | ||
| <string name="update_pooja">Selected To update Registered Pooja details</string> | ||
| <string name="UPDATE">Selected to update donated money details</string> |
There was a problem hiding this comment.
Make this Update donated money details
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="UPDATE">Selected To update donated money details</string> | ||
| <string name="update_pooja">Selected To update Registered Pooja details</string> | ||
| <string name="UPDATE">Selected to update donated money details</string> | ||
| <string name="update_pooja">Selected to update registered pooja details</string> |
There was a problem hiding this comment.
Make this Update registered pooja details
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="people_who_registered_for_pooja">People Who Registered For Pooja</string> | ||
| <string name="people_who_donated_money_for_temple">People Who Donated Money For Temple</string> | ||
| <string name="people_who_registered_for_pooja">People who registered for pooja</string> | ||
| <string name="people_who_donated_money_for_temple">People Who donated money for temple</string> |
There was a problem hiding this comment.
Make the W in Who lower case.
yashk2000
reviewed
Aug 16, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="update">Update</string> | ||
| <string name="error_notSelected">Please select any option</string> | ||
| <string name="fetch_name">name</string> | ||
| <string name="insert_data">Insert Data</string> | ||
| <string name="nothingselected">Nothing selected</string> | ||
| <string name="custompooja">Custom Pooja</string> | ||
| <string name="amount_in_rs">Amount: Rs.</string> | ||
| <string name="amount_in_rs">Amount: Rs.</string> |
There was a problem hiding this comment.
Revert this change entirely. Don't delete any spaces.
yashk2000
approved these changes
Aug 16, 2019
immadisairaj
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #114
Changes: Refactored the app code in delete pooja/donation and formatted sentences accordingly.