Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

chore: Update README.md #62

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Conversation

ajay-prabhakar
Copy link
Member

@ajay-prabhakar ajay-prabhakar commented Jun 24, 2019

Fixed #60

changes

updated readme.md with recent activities UI

Copy link
Member

@immadisairaj immadisairaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semantic PR

@ajay-prabhakar ajay-prabhakar changed the title Update README.md Chore: Update README.md Jun 24, 2019
@yashk2000
Copy link
Member

@Chromicle make it chore: Update .......

Copy link
Member

@yashk2000 yashk2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chromicle please also add the part about spotless. Tell contributors that they need to run ./gradlew spotlessApply before sending a pr to maintain code quality.

Instead of adding it in readme we will add in PR template like checkbox
So they can remember before sending PR

@immadisairaj immadisairaj changed the title Chore: Update README.md chore: Update README.md Jun 24, 2019
@yashk2000
Copy link
Member

@Chromicle do not edit existing comments. Write a new comment of your own while responding.

Copy link
Member

@yashk2000 yashk2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chromicle, not 7 screenshots. Limit it to 6. Otherwise there will be one extra screenshot in an entire row of it's own which looks a bit weird.

@ajay-prabhakar
Copy link
Member Author

@Chromicle, not 7 screenshots. Limit it to 6. Otherwise, there will be one extra screenshot in an entire row of its own which looks a bit weird.

Yeah, I also think about it I updated to 6 screenshots

@yashk2000
Copy link
Member

Great. Just squash your commits please :)

Update README.md

add version badges

chore: create contributing.md

feat: user can fetch multipule details in readAll (amfoss#61)

* feat:allow user to fetch multipule details

Allow to fetch multipule details

proper intend

Made builds pass

Allow to fetch multipule details

updated

Make spotless build passed

chore: create contributing.md

Make spotless build passed

Make spotless build passed

* Make spotless build passed

Update README.md
Copy link
Member

@yashk2000 yashk2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

@immadisairaj immadisairaj merged commit eca3f05 into amfoss:development Jun 25, 2019
@ajay-prabhakar ajay-prabhakar deleted the readme branch July 15, 2019 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update screenshots in readme.
3 participants