-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semantic PR
@Chromicle make it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chromicle please also add the part about spotless. Tell contributors that they need to run
./gradlew spotlessApply
before sending a pr to maintain code quality.
Instead of adding it in readme we will add in PR template like checkbox
So they can remember before sending PR
@Chromicle do not edit existing comments. Write a new comment of your own while responding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chromicle, not 7 screenshots. Limit it to 6. Otherwise there will be one extra screenshot in an entire row of it's own which looks a bit weird.
Yeah, I also think about it I updated to 6 screenshots |
Great. Just squash your commits please :) |
Update README.md add version badges chore: create contributing.md feat: user can fetch multipule details in readAll (amfoss#61) * feat:allow user to fetch multipule details Allow to fetch multipule details proper intend Made builds pass Allow to fetch multipule details updated Make spotless build passed chore: create contributing.md Make spotless build passed Make spotless build passed * Make spotless build passed Update README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😄
Fixed #60
changes
updated readme.md with recent activities UI