fix: Toast Duration #89

AnoopkRajan · 2019-07-18T12:34:51Z

Fixed: #79
Changes: Toast duration has been reduced.

yashk2000

Thanks for sending a pr. Just a few things more that you need to take care of .
Please fill in the pr template with the details mentioned. Also fix the failing build. Once you're done don't forget to squash the commits.

AnoopkRajan · 2019-07-18T16:24:01Z

@yashk2000
Thanks for the review.
Working on the build fail.
format will be updated next PR onward.

ajay-prabhakar · 2019-07-19T06:11:12Z

app/src/main/java/org/amfoss/templeapp/activities/DeleteData.java

                            .show();
                    break;
                case R.id.radio_pooja:
                    binding.totalView.setVisibility(View.VISIBLE);
                    flag = 1;
-                    Toast.makeText(getBaseContext(), getString(R.string.delete_pooja), Toast.LENGTH_LONG)
+                    Toast.makeText(getBaseContext(), getString(R.string.delete_pooja), Toast.LENGTH_SHORT)


Change to getBaseContext instead of getApplicationContext as this is that preferred way since this Context lives untill Application shuts down.
I am seeing so many unused changes please change that

@Chromicle
Thanks for the review.
Can you please highlight the unused changes .
So that i can know the specifics.

Should i also change to getBaseContext instead of getApplicationContext in MainActivity ?

ajay-prabhakar

There are 59 file changes please change them

ajay-prabhakar · 2019-07-19T08:36:22Z

MyApplication/app/build.gradle

+android {
+    compileSdkVersion 29
+    buildToolsVersion "29.0.0"
+    defaultConfig {


This is not templeApp gradle file you created some thing application named MyApplicattion
Please revert all these

@Chromicle
Yes , I overlooked this fault .
working on it.

AnoopkRajan

Have done the Requested modifications.
Awaiting for review and approval

yashk2000

To many unnecessary changes in the idea files. Do not add the idea files while pushing your changes please.

immadisairaj

@AnoopkRajan Also can you update the pr template.

gradle.properties

ajay-prabhakar · 2019-07-19T13:58:58Z

@AnoopkRajan Also can you update the pr template.

@AnoopkRajan what he ment is change in Github PR template not in pull_request_template.md

immadisairaj · 2019-07-19T14:22:07Z

gradle.properties

this is not a change. then why is it here. can you rectify that

it is not yet reverted.

immadisairaj · 2019-07-19T14:22:44Z

pull_request_template.md

@@ -0,0 +1,14 @@
+# Related Issue


this is not what I meant. You have to fill the PR template for the Pull Request

please revert this file

immadisairaj · 2019-07-19T14:24:15Z

Fixed Toast Duration issue .

@AnoopkRajan I meant change this according to the PR template

AnoopkRajan · 2019-07-19T16:37:27Z

Fixed Toast Duration issue .

@AnoopkRajan I meant change this according to the PR template

Have added the PR template.

yashk2000 · 2019-07-19T17:46:11Z

.github/PULL_REQUEST_TEMPLATE

@@ -1,5 +0,0 @@
-Fixed #[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]


Why did you delete this file? Revert this please.

yashk2000 · 2019-07-21T16:06:16Z

@AnoopkRajan please revert changes to the pr template. Rest seems to be fine.

AnoopkRajan · 2019-07-23T03:08:07Z

@AnoopkRajan please revert changes to the pr template. Rest seems to be fine.

yes .... i am working on it .

Fix Travis build Update DeleteData.java Update InsertData.java Update ReadAllData.java Update ReadSingleData.java Update UpdateData.java intented Refix gradle build Modified Requested Changes removed deleted code reverted changes changes

yashk2000

Thanks @AnoopkRajan 😄

ajay-prabhakar

@AnoopkRajan great work
Thanks for doing everything with patience 👍

vchrombie · 2019-07-31T12:40:02Z

Thanks, @AnoopkRajan for the PR. 🙂

yashk2000 suggested changes Jul 18, 2019

View reviewed changes

AnoopkRajan closed this Jul 18, 2019

AnoopkRajan reopened this Jul 18, 2019

AnoopkRajan force-pushed the development branch from 0540ca9 to 09805c1 Compare July 19, 2019 05:57

AnoopkRajan changed the title ~~Fix Toast Duration~~ fix:Toast Duration Jul 19, 2019

auto-label bot added the fix label Jul 19, 2019

AnoopkRajan changed the title ~~fix:Toast Duration~~ fix: Toast Duration Jul 19, 2019

ajay-prabhakar suggested changes Jul 19, 2019

View reviewed changes

AnoopkRajan force-pushed the development branch from 812cd88 to 61019d9 Compare July 19, 2019 08:07

ajay-prabhakar reviewed Jul 19, 2019

View reviewed changes

AnoopkRajan force-pushed the development branch 2 times, most recently from effcf08 to 1e8cf29 Compare July 19, 2019 10:19

AnoopkRajan commented Jul 19, 2019

View reviewed changes

yashk2000 suggested changes Jul 19, 2019

View reviewed changes

AnoopkRajan force-pushed the development branch 2 times, most recently from 3be36b0 to 11224f6 Compare July 19, 2019 10:48

immadisairaj suggested changes Jul 19, 2019

View reviewed changes

gradle.properties Outdated Show resolved Hide resolved

AnoopkRajan force-pushed the development branch 3 times, most recently from 884a941 to 42ba927 Compare July 19, 2019 13:19

immadisairaj suggested changes Jul 19, 2019

View reviewed changes

AnoopkRajan force-pushed the development branch 2 times, most recently from e039fb5 to 54c0cd2 Compare July 19, 2019 16:02

yashk2000 reviewed Jul 19, 2019

View reviewed changes

AnoopkRajan force-pushed the development branch from 17d4b9d to e35bc3a Compare July 23, 2019 03:16

Fixed the Toast duration

820d455

Fix Travis build Update DeleteData.java Update InsertData.java Update ReadAllData.java Update ReadSingleData.java Update UpdateData.java intented Refix gradle build Modified Requested Changes removed deleted code reverted changes changes

AnoopkRajan force-pushed the development branch from e35bc3a to 820d455 Compare July 23, 2019 03:21

yashk2000 approved these changes Jul 23, 2019

View reviewed changes

Merge branch 'development' into development

6af205d

ajay-prabhakar approved these changes Jul 24, 2019

View reviewed changes

immadisairaj approved these changes Jul 31, 2019

View reviewed changes

vchrombie merged commit 2345475 into amfoss:development Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Toast Duration #89

fix: Toast Duration #89

AnoopkRajan commented Jul 18, 2019 •

edited

Loading

yashk2000 left a comment

AnoopkRajan commented Jul 18, 2019

ajay-prabhakar Jul 19, 2019

AnoopkRajan Jul 19, 2019 •

edited

Loading

AnoopkRajan Jul 19, 2019

ajay-prabhakar left a comment

ajay-prabhakar Jul 19, 2019

AnoopkRajan Jul 19, 2019

AnoopkRajan left a comment

yashk2000 left a comment

immadisairaj left a comment

ajay-prabhakar commented Jul 19, 2019

immadisairaj Jul 19, 2019

AnoopkRajan Jul 19, 2019

immadisairaj Jul 19, 2019

immadisairaj Jul 19, 2019

immadisairaj Jul 19, 2019 •

edited

Loading

immadisairaj commented Jul 19, 2019 •

edited

Loading

AnoopkRajan commented Jul 19, 2019

yashk2000 Jul 19, 2019

yashk2000 commented Jul 21, 2019

AnoopkRajan commented Jul 23, 2019

yashk2000 left a comment

ajay-prabhakar left a comment

vchrombie commented Jul 31, 2019

		@@ -1,5 +0,0 @@
		Fixed #[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]

fix: Toast Duration #89

fix: Toast Duration #89

Conversation

AnoopkRajan commented Jul 18, 2019 • edited Loading

yashk2000 left a comment

Choose a reason for hiding this comment

AnoopkRajan commented Jul 18, 2019

Choose a reason for hiding this comment

AnoopkRajan Jul 19, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajay-prabhakar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnoopkRajan left a comment

Choose a reason for hiding this comment

yashk2000 left a comment

Choose a reason for hiding this comment

immadisairaj left a comment

Choose a reason for hiding this comment

ajay-prabhakar commented Jul 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

immadisairaj Jul 19, 2019 • edited Loading

Choose a reason for hiding this comment

immadisairaj commented Jul 19, 2019 • edited Loading

AnoopkRajan commented Jul 19, 2019

Choose a reason for hiding this comment

yashk2000 commented Jul 21, 2019

AnoopkRajan commented Jul 23, 2019

yashk2000 left a comment

Choose a reason for hiding this comment

ajay-prabhakar left a comment

Choose a reason for hiding this comment

vchrombie commented Jul 31, 2019

AnoopkRajan commented Jul 18, 2019 •

edited

Loading

AnoopkRajan Jul 19, 2019 •

edited

Loading

immadisairaj Jul 19, 2019 •

edited

Loading

immadisairaj commented Jul 19, 2019 •

edited

Loading