-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error if a non-existing string-type path is passed #103
Conversation
@flferretti what happens if we are in the following case: we have an input |
Yes, but we could also think about something like |
I think that this PR will also be useful to debug the CI failures on the conda-feedstock for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @flferretti and @xela-95! Can we merge this PR?
Yes, now it's ready for review. I added the modification mentioned in #103 (comment). Thanks! |
@Giulero do you think it would be possible to do a minor release after this? So @xela-95 and me can work on conda-forge/adam-robotics-feedstock#10 and conda-forge/adam-robotics-feedstock#12. Thanks a lot! |
Sure! Let's merge this and release. |
This pull request includes a small change to the
get_xml_string
function in thesrc/adam/model/std_factories/std_model.py
file. The change simplifies the condition for converting a string to apathlib.Path
object by removing the redundant check for the existence of the path. In this way, an error will be raised when a non-existing string-type path is passed