-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging feature #10
Conversation
1a3f284
to
f42510d
Compare
f42510d
to
abc4b24
Compare
Somehow I managed to find the cause of the failure on Turns out that Windows paths have a restriction of Now, the file that is being attempted to generate in the step above mentioned is: In 6c943a7 I shortened the name of the directory where |
d5cc4a9
to
a9531b6
Compare
a9531b6
to
66654b5
Compare
Finally all checks are passing! @lrapetti can you proceed with the review? |
0727102
to
4158842
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logger and initial skeleton are there, for me we can merge.
I don't know if it makes any sense to add a line in the CHANGELOG
such that at the first release of the library, we have a list of features.
Done @lrapetti. Thanks for the review, merging. |
Super cool, first PR with implementation elements, well done! |
As per title, this PR adds the text logging utility to the BAF library. In addition, it also adds CI build workflows.
The feature relies on the
[bipedal-locomotion-framework](https://github.com/ami-iit/bipedal-locomotion-framework)
's one, just changing the name/prefix of the logged message tobaf
instead ofblf
.More specifically, the feature relies on the following PR of
blf
which is merged but not yet released: ami-iit/bipedal-locomotion-framework#582.For this reason the tag used is the commit
c1cb3fa3329cae7515de6d453bc099dde2cd0645
and the CI, which mostly relies on conda-based dependencies, installsblf
from source.Related TODOs will be removed once after the next version of
blf
is released.