Add CMake skeleton #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
reviewed
Jul 13, 2021
prashanthr05
approved these changes
Jul 13, 2021
traversaro
approved these changes
Jul 13, 2021
S-Dafarra
reviewed
Jul 15, 2021
S-Dafarra
approved these changes
Jul 15, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CMake skeleton of the project.
At this stage, we are taking big advantages of the work done in
bipedal-locomotion-framework, and more we are planning to "steal" (e.g. for #6), so big kudos to @dic-iit/blf-developers. Please, feel free to give your feedback in case there is any problem with that / if you want to discuss this choice / or if you have any suggestion.Clearly, thinking of having a common CMake package tool is appealing, but, at this stage, I don't think there is anyone willing to maintain it as a separate tool (we can also call out the rule of three, as @traversaro mentioned). For the time being, we can keep an eye open when bug/fix arises in blf cmake structure (like ami-iit/bipedal-locomotion-framework#350).