Fix some bugs in the python script for generating urdf files #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
requested review from
traversaro,
prashanthr05 and
S-Dafarra
S-Dafarra
reviewed
Sep 24, 2020
Comment on lines
+19
to
+21
| self.length = size[0] | ||
| self.width = size[1] | ||
| self.height = size[2] |
There was a problem hiding this comment.
To avoid the same problem again, how did you determine this relation? Any piece of documentation worth to be linked?
There was a problem hiding this comment.
To avoid the same problem again, how do you determined this relation? Any piece of documentation worth to be linked?
Actually my first idea was having a vector containing [x y z] dimensions that I called [length width height] then by mistake I confused the index.
I tried to replicate the order in the urdf file. I can add some documentation there
There was a problem hiding this comment.
Here I added some documentation 016b8ca, let me know if it's fine
S-Dafarra
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs in
generate_stairs_urdf.pyandGenerateAndAddUrdfModel.cmake