Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compilation of Contact library independent from Planners library #141

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Make compilation of Contact library independent from Planners library #141

merged 1 commit into from
Nov 25, 2020

Conversation

prashanthr05
Copy link
Collaborator

No description provided.

@prashanthr05 prashanthr05 self-assigned this Nov 12, 2020
S-Dafarra
S-Dafarra approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should something be added to the changelog?

@prashanthr05
Copy link
Collaborator Author

Should something be added to the changelog?

If we are going to add specifically about Contact library on the README, then I guess it makes sense to update also the CHANGELOG. Otherwise, I think it's safe to ignore it.

@S-Dafarra
Copy link
Member

Should something be added to the changelog?

If we are going to add specifically about Contact library on the README, then I guess it makes sense to update also the CHANGELOG. Otherwise, I think it's safe to ignore it.

As you prefer.

@prashanthr05
Copy link
Collaborator Author

Actually

Implement Contact library. (#43 and #45)

This line already exists in the CHANGELOG. Since we are yet to release a new version, I think we can stick with the default.

@prashanthr05 prashanthr05 changed the title [Contact] make compilation independent from Planners Make compilation of Contact library independent from Planners library Nov 12, 2020
@prashanthr05 prashanthr05 mentioned this pull request Nov 12, 2020
Merged
@GiulioRomualdi
Copy link
Member

Let me know if I can merge it

@prashanthr05
Copy link
Collaborator Author

@GiulioRomualdi please see the discussion here #142 (comment).
We need to consider that design decision before merging this.

@prashanthr05
Copy link
Collaborator Author

Give the comment in #142 (comment), we could proceed with the merge.

@prashanthr05 prashanthr05 reopened this Nov 13, 2020
@prashanthr05
Copy link
Collaborator Author

prashanthr05 commented Nov 13, 2020 •
edited
Loading

Sorry I mistakenly clicked on Close with comment instead of comment ;D

@prashanthr05 prashanthr05 mentioned this pull request Nov 19, 2020
Merged
1 task
@S-Dafarra
Copy link
Member

We can merge this, right?

GiulioRomualdi
GiulioRomualdi approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge

@S-Dafarra S-Dafarra merged commit 862254f into ami-iit:master Nov 25, 2020
@prashanthr05 prashanthr05 deleted the cmake/refactor-contact branch November 25, 2020 09:34
@prashanthr05
Copy link
Collaborator Author

Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

@GiulioRomualdi GiulioRomualdi GiulioRomualdi approved these changes

Assignees

@prashanthr05 prashanthr05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prashanthr05 @S-Dafarra @GiulioRomualdi