[RobotInterface] Fix MAS sensors in YarpSensorBridge and remove cameras from SensorBridge #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanthr05
added
[disable changelog ci]
bugfix
| { | ||
| if (sensorInterface == nullptr) | ||
| { | ||
| return -1; |
There was a problem hiding this comment.
size_t is an unsigned integer. I'm afraid that this will return the maximum number
There was a problem hiding this comment.
Thank you! Fixed in d4dcb8a.
| @@ -809,7 +712,7 @@ struct YarpSensorBridge::Impl | |||
| * Attach generic IMU sensor types and MAS inertials | |||
| */ | |||
| bool attachAllInertials(const yarp::dev::PolyDriverList& devList) | |||
| { | |||
| { | |||
There was a problem hiding this comment.
Fixed in d4dcb8a.
| @@ -824,7 +727,7 @@ struct YarpSensorBridge::Impl | |||
| return false; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Fixed in d4dcb8a.
| m_pimpl->bridgeInitialized = true; | ||
| return true; | ||
| } | ||
|
|
||
| bool YarpSensorBridge::setDriversList(const yarp::dev::PolyDriverList& deviceDriversList) | ||
| { | ||
| { |
There was a problem hiding this comment.
Fixed in d4dcb8a.
| @@ -106,13 +94,12 @@ bool YarpSensorBridge::setDriversList(const yarp::dev::PolyDriverList& deviceDri | |||
| << std ::endl; | |||
| return false; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Fixed in d4dcb8a.
prashanthr05
force-pushed
the
sensor-bridge/fix-mas-and-remove-cameras
branch
from
19c9f53
to
d4dcb8a
Compare
GiulioRomualdi
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
@prashanthr05 tell me if you want to reorganize the commits otherwise I can merge
|
@GiulioRomualdi I cherry-picked a commit from another branch, so I think it will be ok to merge to prevent conflicts while merging the other branch. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes,