Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimeVaryingDCMPlanner] restructure of setDCMReference() and setContactPhaseList() #220

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Mar 2, 2021

#208 implements setDCMReference() however the user had to call the function after setContactPhaseList(). Thanks to this PR, setDCMReference() does not depends on setContactPhaseList() and the user can call it whenever their want.

cc @paolo-viceconte

@GiulioRomualdi GiulioRomualdi force-pushed the improve/TimeVaryingDCMPlanner branch from 716a8bf to e10b5e6 Compare March 2, 2021 16:33
Copy link
Collaborator

@prashanthr05 prashanthr05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me! But I would wait for @S-Dafarra approval as well.

Copy link
Member

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple suggestion. So basically, you can set the initial dcm condition without changing the foot list, right?

@@ -491,6 +494,8 @@ struct TimeVaryingDCMPlanner::Impl
bool setupOptimizationProblem(const ContactPhaseList& contactPhaseList,
const DCMPlannerState& initialState)
{
constexpr auto errorPrefix = "[TimeVaryingDCMPlanner::Impl::setupOptimizationProblem] ";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add some tags to distinguish between errors and info messages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do it in a separate PR for all the error/warning/info in the repo. Indeed now all the errors/warnings/info are printed with cerr and there is not a common function to call. #137 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not referring to cerr but rather to the message itself. It is not clear whether the message is an error or not. I was suggesting adding something like [ERROR] since it is going to be much easier to find them in the middle of tons of other messages.

Copy link
Member Author

@GiulioRomualdi GiulioRomualdi Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On that one I agree. Done in 7999c2f

@GiulioRomualdi
Copy link
Member Author

GiulioRomualdi commented Mar 3, 2021

So basically, you can set the initial dcm condition without changing the foot list, right?

This possibility was already implemented in the first version. With this PR the user can set the reference dcm (used for regularization) independently from the foot list

@GiulioRomualdi
Copy link
Member Author

Comment #220 (comment) updated. @S-Dafarra

@GiulioRomualdi GiulioRomualdi merged commit b170271 into master Mar 3, 2021
@GiulioRomualdi GiulioRomualdi deleted the improve/TimeVaryingDCMPlanner branch March 3, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants