Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common Python files to gitignore #338

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Conversation

diegoferigo
Copy link
Member

No description provided.

@diegoferigo
Copy link
Member Author

ping @GiulioRomualdi @S-Dafarra

@S-Dafarra
Copy link
Member

Really sorry for the delay, I missed it (twice). Overall looks good to me. My only concern is that the entries are much more, many of them are not directly related to python. Would it be possible to have those folders generated in a subfolder, from which it would be easier to ignore?

@diegoferigo
Copy link
Member Author

The new content is a direct copy-paste from the official gitignores that Github uses for Python projects. What kind of problems do you think could happen? We're already using this ignores in many C++ / Python projects. If in the future there would be a clash with a new file / folder (quite uncommon), it would be trivial to spot the problem since the files would not show up in git status.

@S-Dafarra
Copy link
Member

The new content is a direct copy-paste from the official gitignores that Github uses for Python projects. What kind of problems do you think could happen? We're already using this ignores in many C++ / Python projects. If in the future there would be a clash with a new file / folder (quite uncommon), it would be trivial to spot the problem since the files would not show up in git status.

That's also a good point. Ok for me then.

@diegoferigo
Copy link
Member Author

Awesome, thanks! Resolved the conflict with the new online interface. It's the first time I use it, very helpful :)

@GiulioRomualdi
Copy link
Member

The CI failure is not related to this PR. please check here #353

I think we can merge it

@GiulioRomualdi GiulioRomualdi merged commit f41d64f into master Jul 2, 2021
@GiulioRomualdi GiulioRomualdi deleted the diegoferigo-patch-1 branch July 2, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants