Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the duplicate code in IK and TSID #364

Merged
merged 13 commits into from
Jul 12, 2021
Merged

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Jul 9, 2021

This PR tries to reduce the duplicate code in IK and TSID and implements what has been discussed in #363.

I implemented the ILinearTaskSolver interface from which TSID and IK inherit. I also implemented TSIDLinearTask and IKLinearTask that are two specializations of LinearTask. Each IK task will inherit from IKLinearTask while each TSID task from TSIDLinearTask.

No actions are required by the user to adapt the consumer libraries to this new implementation.

cc @traversaro @isorrentino @S-Dafarra @paolo-viceconte

@GiulioRomualdi GiulioRomualdi self-assigned this Jul 12, 2021
@GiulioRomualdi GiulioRomualdi marked this pull request as ready for review July 12, 2021 11:15
@GiulioRomualdi GiulioRomualdi changed the title Restructure IK and TSID Reduce the duplicate code in IK and TSID Jul 12, 2021
Copy link
Member

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your plan for IKLinearTask and TSIDLinearTask? At the moment they simply inherit from LinearTask, so I was wondering why not using LinearTask directly. Are you planning to add new methods in the future?

@GiulioRomualdi
Copy link
Member Author

The idea is to avoid that someone uses a IK task in TSID and viceversa

@S-Dafarra
Copy link
Member

The idea is to avoid that someone uses a IK task in TSID and viceversa

Ah, I see. I also see why you used the template then, nice!

@S-Dafarra
Copy link
Member

S-Dafarra commented Jul 12, 2021

The macOS job failed with error

2021-07-12T11:15:39.5015400Z Can't find any online and idle self-hosted or hosted runner in the current repository, account/organization that matches the required labels: 'macOS-latest'
2021-07-12T11:15:39.5015541Z Found online and busy hosted runner(s) in the current repository's organization account that matches the required labels: 'macOS-latest'. Hit concurrency limits on the hosted runners. Waiting for one of them to get assigned for this job.
2021-07-12T11:15:39.5015572Z Waiting for a hosted runner in 'organization' to pick this job...

Maybe it should be macos-latest (with the lowercase o) in https://github.com/dic-iit/bipedal-locomotion-framework/blob/master/.github/workflows/ci.yml#L55 instead (see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners)?

@GiulioRomualdi GiulioRomualdi merged commit a818387 into master Jul 12, 2021
@GiulioRomualdi GiulioRomualdi deleted the restructure/IK_TSID branch July 12, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants