Implement AngularMomentum task in the IK component #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
requested review from
traversaro,
S-Dafarra and
paolo-viceconte
traversaro
requested changes
Nov 8, 2021
|
|
||
| /** | ||
| * AngularMomentumTask is a concrete implementation of the IK::Task. Please use this element if you | ||
| * want to control the position and the orientation of a given frame rigidly attached to the robot. |
There was a problem hiding this comment.
Yes I fixed the documentation
GiulioRomualdi
force-pushed
the
IK/AngularMomentum
branch
from
b66fddc to
8bdf995
Compare
traversaro
reviewed
Nov 8, 2021
| def test_angular_momentum_task(): | ||
|
|
||
| # retrieve the model | ||
| model_url = 'https://raw.githubusercontent.com/robotology/icub-models/master/iCub/robots/iCubGazeboV2_5/model.urdf' |
There was a problem hiding this comment.
Perhaps you may want to get a fixed release to avoid that a change in icub-models breaks this test?
There was a problem hiding this comment.
I think that as soon as we can start using pybind11 iDynTree bindings we can switch to iDynTree.get_random_chain(10)
There was a problem hiding this comment.
In that case, we need to remind to set a fixed seed.
traversaro
reviewed
Nov 8, 2021
| * linear and angular velocity expressed in mixed representation and the joint velocities. | ||
| * The task represents the following equation | ||
| * \f[ | ||
| * A_{cmm_\omega} \nu = {}^G[A} h_\omega ^* |
There was a problem hiding this comment.
Not sure the correct fix, but G[A} probably needs to be fixed?
GiulioRomualdi
force-pushed
the
IK/AngularMomentum
branch
from
8bdf995 to
3974372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task can be used to control a desired angular momentum in the IK.
This can be useful to generate a swing motion of the arms when the robot is position control