Add external wrenches logging to yarp robot logger device #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isorrentino
force-pushed
the
addExtWrenchLogging
branch
from
3c0e59d to
7c107df
Compare
…rDevice and fix files of existing robots
isorrentino
force-pushed
the
addExtWrenchLogging
branch
from
3393cfb to
1d265bd
Compare
Comment on lines
76
to
78
| bool m_streamWrenches{false}; | ||
| bool m_streamFTs{false}; | ||
| bool m_streamInertials{false}; |
There was a problem hiding this comment.
Those parameters are not used 😄
There was a problem hiding this comment.
In theory, you do need them. Indeed if wrench are streamed the associated map is empty
There was a problem hiding this comment.
There was a problem hiding this comment.
Got your point. Changed again the code.
devices/YarpRobotLoggerDevice/include/BipedalLocomotion/YarpRobotLoggerDevice.h
Outdated
Show resolved
Hide resolved
…botLoggerDevice.h Co-authored-by: Giulio Romualdi <giulio.romualdi@gmail.com>
|
PR ready again for review. |
isorrentino
force-pushed
the
addExtWrenchLogging
branch
from
55e8b42 to
2a0cb1d
Compare
|
@GiulioRomualdi please proceed with the merge without my review, if you think the changes are good. |
GiulioRomualdi
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.