Update YarpRobotLoggerDevice documentation #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lrapetti You are right. I modified the |
isorrentino
requested changes
Dec 2, 2021
Co-authored-by: Giulio Romualdi <giulio.romualdi@gmail.com>
lrapetti
force-pushed
the
update-YARPRobotLoggerDevice-doc
branch
from
66fcca3 to
ff3e332
Compare
|
Hi @isorrentino @GiulioRomualdi, sorry for taking long. I have rebased the PR on top of the master and done the requested changes. Let me know if further changes are required |
|
Thank you @lrapetti I will squash the commits and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the
YarpRobotLoggerDevicewas not up-to-date, I have replaced it with a more general one with all the new features.I have also noticed currently, as far as I see, the devices are not mentioned in the main
README.md. Not sure if that's because they are still not stable, or it is simply missing.cc @isorrentino