Add the possibility to log only a subset of text logging ports #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
approved these changes
Sep 13, 2022
GiulioRomualdi
force-pushed
the
logger/text_logging_substrings
branch
from
61eb437 to
c1de8d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in time, we (@S-Dafarra and I) noticed that storing the text with the logger is time-consuming. This PR gives the user the possibility to log only a subset of text logging ports by specifying substrings that need to be contained in the port name.
If one of those substrings is found then the port is logged.
In order to do so, I introduced
text_logging_subnamesparameter. This parameter is optional. If not passed all the logs are savedThis is an example of configuration