Fix compatibility with OpenCV 4.7.0 #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
approved these changes
Jan 30, 2023
Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
|
I guess also @prashanthr05 may be interested on this. |
| @@ -55,6 +55,11 @@ class ArucoDetector::Impl | |||
| /** | |||
| * Utility map for choosing Aruco marker dictionary depending on user parameter | |||
| */ | |||
| // TODO(traversaro): when we drop support for OpenCV < 4.7.0, we can cleanup this part | |||
| // we can also check if there are other dictionary that should be added here | |||
| #if (CV_VERSION_MAJOR >= 5) || (CV_VERSION_MAJOR == 4 && CV_VERSION_MINOR >= 7) | |||
There was a problem hiding this comment.
Yes, there are certainly other dictionaries to be added here. I remember experiencing this issue earlier and purposefully leaving out some dictionaries from the lookup.
Apriltags are not added here. https://docs.opencv.org/3.4/dc/df7/dictionary_8hpp.html
GiulioRomualdi
approved these changes
Jan 31, 2023
|
Thank you @traversaro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #586 .