Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the JointLimitsTask for the IK #603

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Conversation

GiulioRomualdi
Copy link
Member

This closes #530

cc @shikui08

src/IK/src/JointLimitsTask.cpp Outdated Show resolved Hide resolved
src/IK/src/JointLimitsTask.cpp Outdated Show resolved Hide resolved
@S-Dafarra
Copy link
Member

Thinking about it, does it make sense to have a test case in which we check that the joint limits are actually satisfied over time?

@shikui08
Copy link

This closes #530

cc @shikui08

Wow. Great work. Appreciate your efforts~!

@GiulioRomualdi
Copy link
Member Author

Thinking about it, does it make sense to have a test case in which we check that the joint limits are actually satisfied over time?

This part is currently missing

@S-Dafarra
Copy link
Member

Thinking about it, does it make sense to have a test case in which we check that the joint limits are actually satisfied over time?

This part is currently missing

Are you planning to add it, or you prefer to avoid it?

@GiulioRomualdi
Copy link
Member Author

Are you planning to add it, or you prefer to avoid it?

I'm trying to do it

@GiulioRomualdi
Copy link
Member Author

Are you planning to add it, or you prefer to avoid it?

I'm trying to do it

While writing the test I found a bug that I fixed in 4139b0d

@GiulioRomualdi GiulioRomualdi force-pushed the ik/joint_limits branch 2 times, most recently from 929eff0 to 61fab08 Compare February 27, 2023 16:10
@GiulioRomualdi
Copy link
Member Author

In 9fea665 I added a test where I check that the joint limit task is satisfied. I forced the joint to be

$$ q^- \le q \le q^+ $$

where I asked

$$ q^- = q^+ = q(t = 0) $$

for some joints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QPInverseKinematics and joint limit constraints?
3 participants