Implement NamedTuple and the CentroidalDynamics classes #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
force-pushed
the
centroidal_dynamics
branch
2 times, most recently
from
a555a30 to
ad12b77
Compare
GiulioRomualdi
force-pushed
the
centroidal_dynamics
branch
from
ad12b77 to
5f16972
Compare
GiulioRomualdi
changed the title
GiulioRomualdi
force-pushed
the
centroidal_dynamics
branch
from
5f16972 to
4752b75
Compare
GiulioRomualdi
force-pushed
the
centroidal_dynamics
branch
2 times, most recently
from
6805229 to
8f203bd
Compare
GiulioRomualdi
force-pushed
the
centroidal_dynamics
branch
from
7155966 to
adef889
Compare
|
Meta comment. Is |
S-Dafarra
reviewed
Apr 4, 2023
Deal! |
S-Dafarra
reviewed
Apr 5, 2023
GiulioRomualdi
force-pushed
the
centroidal_dynamics
branch
from
b97cbd9 to
ef0bfef
Compare
github-actions
bot
added
🔨 component: GenericContainer
and removed
🔨 component: System
labels
|
I moved named_tuple in GenericContainer |
S-Dafarra
reviewed
Apr 5, 2023
...uousDynamicalSystem/include/BipedalLocomotion/ContinuousDynamicalSystem/CentroidalDynamics.h
Outdated
Show resolved
Hide resolved
GiulioRomualdi
force-pushed
the
centroidal_dynamics
branch
2 times, most recently
from
0086ffd to
1af797e
Compare
S-Dafarra
approved these changes
Apr 6, 2023
src/GenericContainer/include/BipedalLocomotion/GenericContainer/NamedTuple.h
Outdated
Show resolved
Hide resolved
src/GenericContainer/include/BipedalLocomotion/GenericContainer/NamedTuple.h
Outdated
Show resolved
Hide resolved
src/GenericContainer/include/BipedalLocomotion/GenericContainer/NamedTuple.h
Outdated
Show resolved
Hide resolved
src/GenericContainer/include/BipedalLocomotion/GenericContainer/NamedTuple.h
Outdated
Show resolved
Hide resolved
src/GenericContainer/include/BipedalLocomotion/GenericContainer/NamedTuple.h
Outdated
Show resolved
Hide resolved
src/GenericContainer/include/BipedalLocomotion/GenericContainer/NamedTuple.h
Outdated
Show resolved
Hide resolved
The following classes have been modified: - DynamicalSystem - FixedBaseDynamics - LinearTimeInvariantSystem - FloatingBaseSystemKinematics - ForwardEuler - FirstOrderSmoother
…only if FRAMEWORK_COMPILE_ContinuousDynamicalSystem
…ContinuousDynamicalSystem
GiulioRomualdi
force-pushed
the
centroidal_dynamics
branch
from
d8ec829 to
1981bde
Compare
|
I applied your changes and I rebased the code. I will wait for the CI and I will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
NamedTupleclass in the System component. I took the implementation from here: https://github.com/GiulioRomualdi/named_tupleThe following classes have been modified to be compliant with
named_tupleMoreover, this PR implements the
CentroidalDynamicsclass