Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation when using CMake 3.26.1 and pybind11 2.4.3 (for example on Ubuntu 20.04 GitHub Actions image) #643

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Fix compilation when using CMake 3.26.1 and pybind11 2.4.3 (for example on Ubuntu 20.04 GitHub Actions image) #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,6 @@ jobs:
mkdir -p /usr/share/librealsense2/presets
sudo apt-get install librealsense2-dev

# Workaround for https://github.com/ami-iit/bipedal-locomotion-framework/issues/636
- name: Cmake 3.25.3 [Ubuntu]
if: startsWith(matrix.os, 'ubuntu')
run: |
curl -sL https://github.com/Kitware/CMake/releases/download/v3.25.3/cmake-3.25.3-linux-x86_64.sh -o cmakeinstall.sh \
&& chmod +x cmakeinstall.sh \
&& sudo ./cmakeinstall.sh --prefix=/usr/local --exclude-subdir \
&& rm cmakeinstall.sh

- name: Cache Source-based Dependencies
id: cache-source-deps
uses: actions/cache@v3
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ All notable changes to this project are documented in this file.
- Return an error if an invalid `KinDynComputations` object is passed to `QPInverseKinematics::build()` (https://github.com/ami-iit/bipedal-locomotion-framework/pull/622)
- Fix `QPTSIF` documentation (https://github.com/ami-iit/bipedal-locomotion-framework/pull/634)
- Fix error messages in `QPTSID` class (https://github.com/ami-iit/bipedal-locomotion-framework/pull/639)
- Fix compilation failure when using CMake 3.26.1 and pybind11 2.4.3 (https://github.com/ami-iit/bipedal-locomotion-framework/pull/643)

## [0.12.0] - 2023-03-07
### Added
Expand Down
9 changes: 9 additions & 0 deletions cmake/BipedalLocomotionFrameworkDependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@
include(BipedalLocomotionFrameworkFindDependencies)
include(BipedalLocomotionDependencyClassifier)

# Workaround for issue that occurs with CMake 3.26.1 and pybind11 2.4.3
# see https://github.com/ami-iit/bipedal-locomotion-framework/issues/636
# This is done here as it needs to be done before any call (even transitive)
# to find_package(pybind11)
# It can be removed once pybind11 2.4.3 is not supported anymore
if(NOT DEFINED CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 17)
endif()

################################################################################
########################## Mandatory dependencies ##############################

Expand Down