Implement robot dynamics estimator - PR1 #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isorrentino
changed the title
isorrentino
changed the title
S-Dafarra
reviewed
May 2, 2023
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModel.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModel.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModel.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModelKinDynWrapper.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModelKinDynWrapper.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModelKinDynWrapper.h
Outdated
Show resolved
Hide resolved
isorrentino
force-pushed
the
mergeRobotDynamicsEstim/pr1
branch
from
882b2fa to
8e8a3b7
Compare
S-Dafarra
reviewed
May 2, 2023
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModel.h
Show resolved
Hide resolved
src/Estimators/tests/RobotDynamicsEstimator/SubModelKinDynWrapperTest.cpp
Outdated
Show resolved
Hide resolved
isorrentino
force-pushed
the
mergeRobotDynamicsEstim/pr1
branch
from
8e8a3b7 to
42f84ec
Compare
S-Dafarra
approved these changes
May 2, 2023
GiulioRomualdi
approved these changes
May 2, 2023
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModel.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModel.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModel.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModelKinDynWrapper.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/RobotDynamicsEstimator/SubModelKinDynWrapper.h
Outdated
Show resolved
Hide resolved
|
The failure of the CI is not related to this PR. Merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @GiulioRomualdi and @S-Dafarra, as anticipated in #615 (comment) here is a first PR.
This PR modifies some interfaces and adds some methods to the already merged classes
SubModelandSubModelKinDynWrapper.