Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement robot dynamics estimator - PR2 #662

Merged

Conversation

isorrentino
Copy link
Collaborator

This PR implements the base class Dynamics which can be extended to implement specific dynamics describing the process model and the measurement model. Together with this base class I already added two specific models:

  • the ZeroVelocityDynamics defines a dynamic model having a null first derivative
  • the JointVelocityStateDynamics describes the dynamic model of the robot joints.

@isorrentino isorrentino self-assigned this May 3, 2023
@isorrentino isorrentino requested a review from S-Dafarra as a code owner May 3, 2023 10:03
@isorrentino isorrentino force-pushed the mergeRobotDynamicsEstim/pr2 branch 3 times, most recently from 224ddb5 to fd0bf89 Compare May 3, 2023 14:45
@isorrentino isorrentino force-pushed the mergeRobotDynamicsEstim/pr2 branch 2 times, most recently from 205113d to b5142ad Compare May 4, 2023 07:45
@isorrentino isorrentino requested a review from GiulioRomualdi May 4, 2023 07:50
@isorrentino isorrentino force-pushed the mergeRobotDynamicsEstim/pr2 branch from b5142ad to eb94b29 Compare May 4, 2023 08:06
Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minors comments

* x_{k+1} = x_{k}
* \f]
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


class ConstantMeasurementModel : public Dynamics
{
UKFInput m_ukfInput;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is missing

* | `initial_covariance` | `vector` | Initial state covariances | Yes |
* | `dynamic_model` | `string` | Type of dynamic model describing the state dynamics. | Yes |
* | `elements` | `vector` | Vector of strings describing the list of sub variables composing the state associated to this dynamics.| No |
* | `dT` | `double` | Sampling time. | Yes |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* | `dT` | `double` | Sampling time. | Yes |
* | `dT` | `chrono::nanoseconds` | Sampling time. | Yes |

* x_{k+1} = x_{k}
* \f]
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


class ZeroVelocityStateDynamics : public Dynamics
{
UKFInput m_ukfInput;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment missing

@isorrentino isorrentino force-pushed the mergeRobotDynamicsEstim/pr2 branch from eb94b29 to 4bedeb4 Compare May 4, 2023 17:56
@isorrentino isorrentino requested a review from GiulioRomualdi May 4, 2023 17:57
@GiulioRomualdi GiulioRomualdi merged commit 8570ae6 into ami-iit:master May 4, 2023
@isorrentino isorrentino deleted the mergeRobotDynamicsEstim/pr2 branch May 4, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants