Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable depth logging in YarpRobotLoggerDevice #672

Merged
merged 4 commits into from
May 18, 2023
Merged

Enable depth logging in YarpRobotLoggerDevice #672

merged 4 commits into from
May 18, 2023

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented May 16, 2023 •
edited
Loading

This PR:

  1. adds the possibility to log RGBD stream in the YarpRobotLoggerDevice 35e2a38
  2. Fixes some bugs in YarpCameraBridge 6e9074c

@GiulioRomualdi GiulioRomualdi force-pushed the YarpRobotLogger_depth branch from 03ad870 to e3b91ae Compare May 16, 2023 20:18
@GiulioRomualdi GiulioRomualdi self-assigned this May 17, 2023
@GiulioRomualdi GiulioRomualdi force-pushed the YarpRobotLogger_depth branch from a1887fa to 3fedce3 Compare May 17, 2023 13:04
@GiulioRomualdi
Bugfixes in YarpCameraBridge
6e9074c 
- Fix the metadata assignment of the rgbd cameras
- Fix the RGB to BGR conversion in YarpCameraBridge for FlexImage
- Format ICameraBridge.h file
@GiulioRomualdi GiulioRomualdi force-pushed the YarpRobotLogger_depth branch from c1329b0 to ed69546 Compare May 18, 2023 12:35
@GiulioRomualdi GiulioRomualdi marked this pull request as ready for review May 18, 2023 12:38
@GiulioRomualdi GiulioRomualdi requested a review from S-Dafarra as a code owner May 18, 2023 12:38
@GiulioRomualdi GiulioRomualdi changed the title Yarp robot logger depth Enable depth logging in YarpRobotLoggerDevice May 18, 2023
@GiulioRomualdi GiulioRomualdi requested a review from mebbaid May 18, 2023 13:01
S-Dafarra
S-Dafarra approved these changes May 18, 2023
View reviewed changes
devices/YarpRobotLoggerDevice/src/YarpRobotLoggerDevice.cpp Outdated
m_videoWriters[rgbCameras[i]].fps = rgbFPS[i];
m_videoWriters[cameraNames[i]].fps = fps[i];

// this means
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops yes :)

@GiulioRomualdi GiulioRomualdi force-pushed the YarpRobotLogger_depth branch from 9e34b7e to 614d046 Compare May 18, 2023 14:39
@GiulioRomualdi GiulioRomualdi merged commit 000973a into master May 18, 2023
@GiulioRomualdi GiulioRomualdi deleted the YarpRobotLogger_depth branch May 18, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

@mebbaid mebbaid Awaiting requested review from mebbaid

Assignees

@GiulioRomualdi GiulioRomualdi

Labels
🔨 component: RobotInterface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiulioRomualdi @S-Dafarra