Findonnxruntime: improve header detection #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can test it immediately |
|
It works fine with conda! I also updated the conda ci to install the right version of onnxruntime |
GiulioRomualdi
approved these changes
May 22, 2023
|
I'm going to fix the test in the next pr I will open in a couple of minutes |
|
#678 will fix the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onnxruntime_cxx_api.hthat is the header actually used inbipedal-locomotion-framework/src/ML/src/MANN.cpp
Line 14 in 000973a
PATH_SUFFIXESto handle the location in which the header is installed in conda-forge packagesHopefully fix #676, even if I did not test it.