Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS compilation of FeasibleContactWrenchTask #680

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix macOS compilation of FeasibleContactWrenchTask #680

merged 1 commit into from
May 24, 2023

Conversation

GiulioRomualdi
Copy link
Member

This fixes the CI failure spotted in #678 (comment)

@GiulioRomualdi GiulioRomualdi self-assigned this May 22, 2023
@GiulioRomualdi GiulioRomualdi requested a review from S-Dafarra as a code owner May 22, 2023 15:08
S-Dafarra
S-Dafarra approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jut for curiosity, why this fixed the issue?

@GiulioRomualdi
Copy link
Member Author

I think that for some reason the macOS Ci when uses brew to install eigen is not able to convert Eigen::Matrix<double, 6, 1, 0>::CompileTimeTraits into an int. This is actually a classic enum

@S-Dafarra
Copy link
Member

I see! Using static_cast?

@GiulioRomualdi
Copy link
Member Author

Let me try

@GiulioRomualdi GiulioRomualdi changed the title Use std::size_t instead of Eigen::Matrix<double, 6, 1, 0>::CompileTimeTraits to check the size of wrench Fix macOS compilation of FeasibleContactWrenchTask May 24, 2023
@GiulioRomualdi
Copy link
Member Author

Let's see if the CI passes

@GiulioRomualdi
Fix macOS compilation of FeasibleContactWrenchTask
93be430 
Evaluate static cast of Wrenchd::SizeAtCompileTime
@GiulioRomualdi GiulioRomualdi merged commit f4b74fe into master May 24, 2023
@GiulioRomualdi GiulioRomualdi deleted the fix_macos_ci branch May 24, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

Assignees

@GiulioRomualdi GiulioRomualdi

Labels
🔨 component: TSID
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiulioRomualdi @S-Dafarra