-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement QuadraticBezierCurve and MANNAutoregressiveInputBuilder #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
changed the title
Implement QuadraticBezierCurve in Math component
Implement QuadraticBezierCurve and MANNAutoregressiveInputBuilder
May 25, 2023
GiulioRomualdi
force-pushed
the
mann_autoregressive_input_generator
branch
from
May 25, 2023 21:00
5a8e293
to
fcd9c89
Compare
GiulioRomualdi
force-pushed
the
mann_autoregressive_input_generator
branch
2 times, most recently
from
May 26, 2023 08:19
88557dc
to
f66de70
Compare
S-Dafarra
reviewed
May 26, 2023
bindings/python/ML/include/BipedalLocomotion/bindings/ML/MANNAutoregressiveInputBuilder.h
Outdated
Show resolved
Hide resolved
src/ML/include/BipedalLocomotion/ML/MANNAutoregressiveInputBuilder.h
Outdated
Show resolved
Hide resolved
I applied the modification you suggested, @S-Dafarra you can check again it 😄 |
S-Dafarra
approved these changes
Jun 5, 2023
GiulioRomualdi
force-pushed
the
mann_autoregressive_input_generator
branch
from
June 5, 2023 13:44
d3d5b3c
to
0ed1076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
MANNAutoregressiveInputBuilder
that is required to easily generate input for MANN from a joypad. The class does not depend on the joypad since it requires only two vectors. The desired motion direction and the facing direction.