Fix standalone Python bindings workflow #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
force-pushed
the
fixpythonstandalone
branch
from
469c135 to
b86d147
Compare
The patch is working correctly there. |
|
So I can merge this PR plus #695 and release the software |
|
Btw, thank you @traversaro ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#697 introduced an untested and undocumented support for building the Python bindings in a standalone way against an existing compiled version of BLF, that we plan to use in conda-forge packaging. However, that patch was not complete as the CMakeLists.txt in
bindings/pythonstill referred to CMake options that do not exists if an external blf is used.I am testing the patch in conda-forge/bipedal-locomotion-framework-feedstock#30 .