Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YarpRobotLoggerDevice if YARP_ROBOT_NAME is not defined #701

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

GiulioRomualdi
Copy link
Member

This fixes #699

@GiulioRomualdi GiulioRomualdi requested a review from S-Dafarra as a code owner July 6, 2023 17:07
@GiulioRomualdi GiulioRomualdi self-assigned this Jul 6, 2023
@GiulioRomualdi GiulioRomualdi added the bugfix Fix a critical bug in the existing code label Jul 6, 2023
@GiulioRomualdi GiulioRomualdi force-pushed the yarprobotlogger_fix_getenv branch from 9217695 to 4f6f120 Compare July 7, 2023 07:20
@GiulioRomualdi
Copy link
Member Author

We tested the PR on @davidegorbani's setup everything is working as expected.

@GiulioRomualdi GiulioRomualdi merged commit 85917f5 into master Jul 7, 2023
@GiulioRomualdi GiulioRomualdi deleted the yarprobotlogger_fix_getenv branch July 7, 2023 07:22
@davidegorbani
Copy link
Contributor

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a critical bug in the existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YarpRobotLoggerDevice segsfault if YARP_ROBOT_NAME is not defined
2 participants