Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timestamp logging for the cameras #748

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fix timestamp logging for the cameras #748

merged 2 commits into from
Nov 3, 2023

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Nov 3, 2023 •
edited
Loading

With this PR, I saved the timestamps of the frames collected with the YarpRobotLoggerDevice in seconds instead of nanoseconds.

@GiulioRomualdi GiulioRomualdi self-assigned this Nov 3, 2023
@GiulioRomualdi GiulioRomualdi marked this pull request as ready for review November 3, 2023 13:18
@GiulioRomualdi
Copy link
Member Author

The CI macOS fails

ModuleNotFoundError: No module named 'distutils'
CMake Error at bindings/CMakeLists.txt:38 (string):
  string sub-command STRIP requires two arguments.

but it's not related to this PR.

@GiulioRomualdi GiulioRomualdi merged commit 49b6ae8 into master Nov 3, 2023
13 of 15 checks passed
@GiulioRomualdi GiulioRomualdi deleted the fix_logging_timestamp branch November 3, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

Assignees

@GiulioRomualdi GiulioRomualdi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiulioRomualdi @S-Dafarra