-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement VectorsCollectionServer and VectorsCollectionClient classes #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
force-pushed
the
vectors_collection_io
branch
from
November 22, 2023 19:46
b400b2d
to
60f96c3
Compare
GiulioRomualdi
changed the title
Implement VectorsCollectionServer class
Implement VectorsCollectionServer and VectorsCollectionClient classes
Nov 22, 2023
GiulioRomualdi
force-pushed
the
vectors_collection_io
branch
from
November 22, 2023 20:00
fd8435d
to
8ccf55b
Compare
S-Dafarra
reviewed
Nov 23, 2023
src/YarpUtilities/include/BipedalLocomotion/YarpUtilities/VectorsCollectionServer.h
Outdated
Show resolved
Hide resolved
src/YarpUtilities/include/BipedalLocomotion/YarpUtilities/VectorsCollectionServer.h
Outdated
Show resolved
Hide resolved
src/YarpUtilities/include/BipedalLocomotion/YarpUtilities/VectorsCollectionServer.h
Outdated
Show resolved
Hide resolved
Hi @S-Dafarra I modified the code as you suggested, what do you think? |
GiulioRomualdi
force-pushed
the
vectors_collection_io
branch
from
November 23, 2023 15:23
c0c0465
to
7711b8f
Compare
S-Dafarra
reviewed
Nov 23, 2023
src/YarpUtilities/include/BipedalLocomotion/YarpUtilities/VectorsCollectionServer.h
Outdated
Show resolved
Hide resolved
src/YarpUtilities/include/BipedalLocomotion/YarpUtilities/VectorsCollectionServer.h
Outdated
Show resolved
Hide resolved
S-Dafarra
approved these changes
Nov 24, 2023
GiulioRomualdi
force-pushed
the
vectors_collection_io
branch
from
November 24, 2023 09:38
2b0347f
to
50e8dde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substitutes #732.
This PR introduces metadata for the
VectorsCollection
, allowing each component of the vector saved by the logger to have a specific label. This enhancement simplifies data analysis, as it enables the display of associated labels in the robot-log-visualizer, as shown in the following image:To ensure metadata consistency, I've implemented it using the client-server paradigm in YARP. I declared the
VectorsCollectionMetadataService
inVectorsCollection.thrift
. This change enables asynchronous metadata requests for a specific VectorsCollection. This is done thanks to theVectorsCollectionServer
andVectorsCollectionClient
In this context, the
YarpRobotLoggerDevice
functions as a client (VectorsCollectionClient
), while the server must be implemented in the application sending the data.Here's an example of how to use
VectorsCollectionServer
in your code:The
m_vectorsCollectionServer
helps you to handle the data you want to send and to populate the metadata. To use this functionality, callBipedalLocomotion::YarpUtilities::VectorsCollectionServer::populateMetadata
during the configuration phase. Once you have finished populating the metadata you should callBipedalLocomotion::YarpUtilities::VectorsCollectionServer::finalizeMetadata
In the main loop, add the following code to prepare and populate the data:
This is an example of updated application that allows you to correctly fill the metadata: robotology/walking-controllers#158