Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to call BufferedPort::prepare every time VectorsCollectionServer::populateData is called #790

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Avoid to call BufferedPort::prepare every time VectorsCollectionServer::populateData is called #790

merged 4 commits into from
Jan 19, 2024

Conversation

GiulioRomualdi
Copy link
Member

No description provided.

@GiulioRomualdi GiulioRomualdi mentioned this pull request Jan 8, 2024
Closed
@GiulioRomualdi GiulioRomualdi marked this pull request as ready for review January 8, 2024 12:09
@GiulioRomualdi
Copy link
Member Author

If this code approach is fine I will update the walking-controller and the application in blf that streams the data

@GiulioRomualdi GiulioRomualdi self-assigned this Jan 8, 2024
@S-Dafarra S-Dafarra mentioned this pull request Jan 18, 2024
Closed
@GiulioRomualdi
Copy link
Member Author

I tested the modification on the robot, and everything seems to be working as expected. I'm going to finalize the PR this morning, merge it and release the software

@GiulioRomualdi GiulioRomualdi force-pushed the vectors_collection_server_reduce_prepare branch from 66f87c4 to f4cd82b Compare January 19, 2024 10:40
@GiulioRomualdi GiulioRomualdi changed the title Avoid to call BufferedPort::prepare every time VectorsCollectionServer::VectorsCollectionServer is called Avoid to call BufferedPort::prepare every time VectorsCollectionServer::prepareData is called Jan 19, 2024
@GiulioRomualdi GiulioRomualdi changed the title Avoid to call BufferedPort::prepare every time VectorsCollectionServer::prepareData is called Avoid to call BufferedPort::prepare every time VectorsCollectionServer::populateData is called Jan 19, 2024
@GiulioRomualdi GiulioRomualdi enabled auto-merge (squash) January 19, 2024 10:49
@GiulioRomualdi
Copy link
Member Author

In windows the IK test fails with this nice error: https://github.com/ami-iit/bipedal-locomotion-framework/actions/runs/7582705428/job/20652803791?pr=790#step:14:312

@GiulioRomualdi GiulioRomualdi mentioned this pull request Jan 19, 2024
Merged
@GiulioRomualdi
Copy link
Member Author

Let's see if the tests are bugged #797

@GiulioRomualdi
Copy link
Member Author

The test failing is the QP IK with gravity task and for sure it is not related to this PR so I'm going to merge it. However I will open an issue for this since there could be something not consider cc @EhsanRanjbari and @S-Dafarra

@S-Dafarra
Copy link
Member

The test failing is the QP IK with gravity task and for sure it is not related to this PR so I'm going to merge it. However I will open an issue for this since there could be something not consider cc @EhsanRanjbari and @S-Dafarra

It is very weird, that tests started failing all of a sudden and only on Windows. It also fails quite largely, so it is not just a problem of tolerances

@GiulioRomualdi GiulioRomualdi mentioned this pull request Jan 19, 2024
Closed
@GiulioRomualdi GiulioRomualdi merged commit d63fa9f into master Jan 19, 2024
14 of 15 checks passed
@GiulioRomualdi GiulioRomualdi deleted the vectors_collection_server_reduce_prepare branch January 19, 2024 21:18
@traversaro traversaro mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

Assignees

@GiulioRomualdi GiulioRomualdi

Labels
💻 utilities 🔨 component: YarpUtilities 🐍 bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiulioRomualdi @S-Dafarra