Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UnicyclePlanner unit test #815

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

mebbaid
Copy link
Contributor

@mebbaid mebbaid commented Mar 2, 2024

While using the unicycle planner with the centroidal mpc client app. Initially i was using the planner in robotology, then realized that the planner was added to bipedal (with some modifications).

Trying to understand its structure, i typically rely on the unit tests codes and I realized there is not a unit test code for the UnicyclePlanner class. I am not sure if that omission is by design, but in case it is not, I added a unit test. Feel free to discard or merge.

Copy link
Member

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mebbaid! Maybe we can disable the saving to file for the time being

src/Planners/tests/UnicyclePlannerTest.cpp Outdated Show resolved Hide resolved
src/Planners/tests/UnicyclePlannerTest.cpp Outdated Show resolved Hide resolved
mebbaid and others added 2 commits March 4, 2024 09:51
Disable the saving of the data by default

Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
Formatting update

Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
@mebbaid
Copy link
Contributor Author

mebbaid commented Mar 4, 2024

Thanks a lot @mebbaid! Maybe we can disable the saving to file for the time being

Agreed, it was left there while I was testing. Resolved in 87c54e1

Correct tolerance for rotation difference
@GiulioRomualdi GiulioRomualdi merged commit bb058aa into ami-iit:master Mar 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants