Implement the prewrapping in the butterworth filter #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the prewrapping technique, enhancing the frequency response consistency of filters across continuous and discrete domains. By implementing this technique, we ensure uniform performance across different signal representations.
The above plot demonstrates the application of the prewrapping technique, resulting in an improvement in the step response of the filter.
Additionally, this PR addresses an issue related to the
setInput()
method, particularly its compatibility with fixed-sizeEigen::Vectors
.Important
By implementing the prewrapping technique, the Butterworth filter now produces results identical to those obtained using MATLAB with the following command:
This equivalence holds when the same
order
,cutoff_frequency
, andsampling_frequency
parameters are used.