Update blf-logger-with-audio.sh script to support different logger launch file #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…input port audio and launch file
… input port audio and launch file
S-Dafarra
reviewed
Jul 23, 2024
|
If I understood well, you always have to set at least one parameter, otherwise it shows the help text, right? |
No, if run without parameters the defaul ones are set. |
S-Dafarra
approved these changes
Jul 23, 2024
GiulioRomualdi
approved these changes
Jul 24, 2024
traversaro
pushed a commit
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition add default values to both arguments.