Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLERP] Return the first quaternion when the two quaternion are equal #13

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[SLERP] Return the first quaternion when the two quaternion are equal #13

merged 1 commit into from
Nov 29, 2023

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented Nov 29, 2023

This PR fixes #12.
Now the the slerp_step method returns the quaternion q1 when interpolating between q1 and q2 if these two quaternions are equal (or approximately equal).

@Giulero
Copy link
Collaborator Author

Giulero commented Nov 29, 2023

Thanks @S-Dafarra !

@Giulero Giulero merged commit 234f242 into main Nov 29, 2023
8 checks passed
@Giulero Giulero deleted the fix-slerp-step branch January 16, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slerp_step returns NaN if the the angle between the two quaternions is zero
2 participants
@Giulero @S-Dafarra