Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
python3.8
explicitly, that would fail on Ubuntu 22.04, instead just rely on the fact thatpython3.*
is a dependency ofpython3-pip
andpython3-venv
/usr/local
or~/.local
) there is an good chance that something will either do not work inmann-pytorch
installation, or thatmann-pytorch
will break some other workflow. A good alternative is to always suggest to install in a virtual environment. Naive users will execute everything without interfering with the rest of the setup, and expert users that for any reason do not want to install in a venv they will be able to do that if they want.