Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid strict dependencies #3

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Avoid strict dependencies #3

merged 3 commits into from
Sep 13, 2022

Conversation

paolo-viceconte
Copy link
Collaborator

This PR addresses #2.

In particular, it intended to:

  • move the strict repo dependencies (i.e. with exact versions) from the setup.cgf to the requirements.txt file
  • leave in the setup.cgf only lower/upper version bounds of the repo dependencies

@paolo-viceconte paolo-viceconte self-assigned this Sep 12, 2022
traversaro
traversaro reviewed Sep 13, 2022
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
traversaro
traversaro requested changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment on protobuf dep.

@paolo-viceconte @traversaro
Update setup.cfg
cfc52d5 
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
@paolo-viceconte
Copy link
Collaborator Author

A comment on protobuf dep.

Suggestion integrated, thanks!

@paolo-viceconte paolo-viceconte merged commit 5ba7726 into main Sep 13, 2022
@paolo-viceconte paolo-viceconte deleted the avoid_strict_dependencies branch September 13, 2022 09:55
@paolo-viceconte paolo-viceconte mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@paolo-viceconte paolo-viceconte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolo-viceconte @traversaro