Fix problems with zero predictors (#588)

amices · Oct 3, 2023 · 615a1ed · 615a1ed
1 parent 5100464
commit 615a1ed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/edit.setup.R b/R/edit.setup.R
@@ -85,7 +85,7 @@ edit.setup <- function(data, setup,
     }
   }
 
-  if (all(pred == 0L)) {
+  if (all(pred == 0L) && didlog) {
     stop("`mice` detected constant and/or collinear variables. No predictors were left after their removal.")
   }
 

diff --git a/R/sampler.R b/R/sampler.R
@@ -186,7 +186,7 @@ sampler.univ <- function(data, r, where, pred, formula, method, yname, k,
   if (calltype == "pred") {
     vars <- colnames(data)[pred != 0]
     xnames <- setdiff(vars, j)
-    if (length(pred) > 0L) {
+    if (length(xnames) > 0L) {
       formula <- reformulate(xnames, response = j)
       formula <- update(formula, ". ~ . ")
     } else {
-Original file line number
+Diff line change
@@ Expand Up / @@ -85,7 +85,7 @@ edit.setup <- function(data, setup, @@
         }
       }
-      if (all(pred == 0L)) {
+      if (all(pred == 0L) && didlog) {
         stop("`mice` detected constant and/or collinear variables. No predictors were left after their removal.")
       }
@@ Expand Down @@